Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): uplift several outdated frontend packages #29652

Merged
merged 22 commits into from
Aug 6, 2024
Merged

chore(build): uplift several outdated frontend packages #29652

merged 22 commits into from
Aug 6, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Jul 21, 2024 •
edited
Loading

chore(build): uplift several outdated frontend packages

SUMMARY

Part of doing upkeep for the project on front-end side. Notable changes:

  • Upgrade babel-jest to current Jest version. This helps reducing 80+ more packages.
  • Upgrade lerna to latest v8 version. This helps reducing another 80+ more packages.
  • Upgrade react-jsonschema-form to v5 and switch to @rjsf workspace. Also perform appropriate refactoring.
  • Remove unused transform-loader.
  • Upgrade sinon to v18 and perform appropriate refactoring.
  • Update prettier to v3.3.3 in package.json and pre-commit's config.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

All CI should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Jul 21, 2024
@hainenber
Copy link
Contributor Author

Hi folks, anything concerning re: this PR? Should I execute something else to help it moving? 👀

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 28, 2024
@hainenber hainenber force-pushed the uplift-outdated-frontend-packages branch from 964ea25 to 8911f8b Compare July 28, 2024 09:22
@rusackas
Copy link
Member

Hi, I'm re-running CI. Hopefully CI will go green, and we can merge this. Thanks again for your help!

@hainenber
Copy link
Contributor Author

CI is green now 😄

@rusackas
Copy link
Member

rusackas commented Aug 1, 2024

There still seems to be a pre-commit (lining) error to contend with. I'm re-running that CI action in case something went wrong, though :)

@hainenber
Copy link
Contributor Author

There still seems to be a pre-commit (lining) error to contend with. I'm re-running that CI action in case something went wrong, though :)

Oh that's the one I opened the recent PR to deal with :D

rusackas
rusackas reviewed Aug 1, 2024
View reviewed changes
superset-frontend/package.json
"prettier-plugin-packagejson": "^2.4.10",
"process": "^0.11.10",
"react-resizable": "^3.0.5",
"react-test-renderer": "^16.14.0",
"redux-mock-store": "^1.5.4",
"sinon": "^9.0.2",
"sinon": "^18.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite a bump!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plenty of accompanying refactors though 😄

rusackas
rusackas approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI. Really appreciating this sort of work! Hopefully if we keep whittling at all these packages, we'll get to make some of the bigger bumps (i.e. React) before long :)

@hainenber
Copy link
Contributor Author

LGTM, pending CI. Really appreciating this sort of work! Hopefully if we keep whittling at all these packages, we'll get to make some of the bigger bumps (i.e. React) before long :)

Largest hurdle is Enzyme-to-RTL migration but I've got some of that in store ;)

@rusackas
Copy link
Member

rusackas commented Aug 1, 2024

Looks like we need another npm install to get this through... probably my fault for merging dependabot stuff 😓

@hainenber
Copy link
Contributor Author

npm install-ed but sadly the CI had a Chrome crash during 1st E2E :(

@rusackas
Copy link
Member

rusackas commented Aug 5, 2024

It looks like it needs a fresh package-lock file committed. Sorry, these things are hard to keep current! :P

@hainenber
Copy link
Contributor Author

Coming right up with a fresh lock-file :D. Finger-crossed that this one's CI pass 😄 . Hopefully it's gonna be last sync before merge :D

@hainenber
Copy link
Contributor Author

Nice, CI is green now 🥸

@rusackas rusackas merged commit 1c3ef01 into apache:master Aug 6, 2024
34 checks passed
@rusackas
Copy link
Member

rusackas commented Aug 6, 2024

Thank you!

@hainenber hainenber deleted the uplift-outdated-frontend-packages branch August 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@justinpark justinpark justinpark approved these changes

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend dependencies:npm plugins size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainenber @rusackas @justinpark